Built by Maven

PMD Results

The following document contains the results of PMD 7.17.0.

Violations By Priority

Priority 1

civitas.base - civitas/common/TestUtil.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type Error. 33

civitas.common - civitas/bboard/server/RestTemplateResponseErrorHandler.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type Error. 33

civitas.common - civitas/bboard/server/controllers/CloseBoardController.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 58

civitas.common - civitas/common/mix/elementrevelation/VerifyMixElementRevelation.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 36

civitas.common - civitas/common/mix/revelation/GetMixRevelationMeta.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 23

civitas.common - civitas/common/mix/voteelementrevelation/VerifyMixVoteElementRevelation.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 28

civitas.common - civitas/common/mix/votemix/AddVoteAndCommitmentToVoteMix.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 20

civitas.common - civitas/common/mix/votemix/GetReencryptedVoteFromMix.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 25

civitas.common - civitas/common/mix/votemix/GetVoteMixMeta.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 20

civitas.common - civitas/common/votercapabilitysharesandproofs/VerifyVoterCapabilitySharesAndProof.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 42

civitas.externalcrypto - civitas/crypto/messagedigest/TestUtil.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type Error. 11

Priority 2

civitas.crypto - civitas/crypto/parameters/encoder/SafePrimeDecode.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'i' 14

civitas.crypto - civitas/crypto/petcommitment/CombinePETShareDecommitments.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'd' 17

Priority 3

civitas.base - civitas/common/ballotdesign/BallotDesign.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.base - civitas/crypto/CryptoError.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.base - civitas/crypto/ciphertext/ElGamalCiphertext.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.base - civitas/crypto/ciphertext/ElGamalCiphertextish.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5

civitas.base - civitas/crypto/msg/CryptMessage.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5
ShortMethodName Avoid using short method names 6

civitas.base - civitas/crypto/parameters/ElGamalParameters.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.base - civitas/crypto/parameters/PrimePair.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.base - civitas/crypto/publickey/ElGamalPublicKey.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 20

civitas.base - civitas/crypto/signedciphertext/ElGamalSignedCiphertext.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.base - civitas/util/CivitasBigInteger.java

Rule Violation Line
CyclomaticComplexity The class 'CivitasBigInteger' has a total cyclomatic complexity of 20 (highest 3). 14

civitas.base - civitas/util/CivitasBigIntegerFactory.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.base - civitas/util/CivitasBigIntegerInterface.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.base - civitas/util/CivitasBigintegerBase.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5

civitas.base - civitas/util/GetCurrentTime.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.base - civitas/util/InitialTests.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 15
UnitTestShouldUseTestAnnotation Unit tests should use the @Test annotation or wont be run. In case of JUnit 5, test methods might use @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest annotations instead. 25

civitas.base - civitas/common/ConstructTestData.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 11

civitas.base - civitas/common/RandomAnswer.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9
RedundantFieldInitializer Avoid using redundant field initializer for 'step' 10
MutableStaticState Do not use non-final non-private static fields 10

civitas.base - civitas/common/RandomAwareTestBase.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7
MutableStaticState Do not use non-final non-private static fields 8

civitas.base - civitas/common/RandomFillerAnswer.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.base - civitas/common/TestUtil.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'n' 11
MutableStaticState Do not use non-final non-private static fields 11
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 32
AssignmentInOperand Avoid assignment to n in operand 40

civitas.base - civitas/crypto/ciphertext/ElGamalCiphertextTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 42

civitas.base - civitas/crypto/msg/ElgamalMsgTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 14

civitas.base - civitas/util/BasicValuesTestData.java

Rule Violation Line
UseUnderscoresInNumericLiterals Number 7166760217683588212L should separate every third digit with an underscore 16
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 18
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 21
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 84

civitas.base - civitas/util/InitialTestsTest.java

Rule Violation Line
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 12

civitas.base - civitas/util/ReaderAnswer.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12
CloseResource Ensure that resources like this Reader object are closed after use 22

civitas.base - civitas/util/XMLAnswer.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.common - civitas/bboard/common/BBPostRepository.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5

civitas.common - civitas/bboard/common/VerifyBBPost.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/bboard/server/BoardRepository.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5

civitas.common - civitas/bboard/server/GetBoardForId.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.common - civitas/bboard/server/RestTemplateResponseErrorHandler.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 28

civitas.common - civitas/bboard/server/controllers/CloseBoardController.java

Rule Violation Line
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 70
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 77
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 77

civitas.common - civitas/bboard/server/controllers/CommunicableExceptionHandler.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.common - civitas/bboard/server/controllers/GetRestTemplate.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/bboard/server/controllers/NewBoardController.java

Rule Violation Line
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 33

civitas.common - civitas/bboard/server/controllers/PostController.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1–138
ExceptionAsFlowControl Exception thrown at line 90 is caught in this block. 92–94
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 93
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 115
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 135

civitas.common - civitas/bboard/server/controllers/RetrieveHashController.java

Rule Violation Line
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 82

civitas.common - civitas/bboard/server/electioncache/ElectionCacheRepository.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.common - civitas/bboard/server/electioncache/UpdateCache.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.common - civitas/common/CheckAccess.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/common/Configuration.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.common - civitas/common/ConvertFromXml.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.common - civitas/common/ConvertToXml.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.common - civitas/common/GetPrivateKey.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 19
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 24

civitas.common - civitas/common/GetPublicKey.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 18
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 22

civitas.common - civitas/common/LoggerService.java

Rule Violation Line
ServiceClassField Services have only @Autowired fields 11

civitas.common - civitas/common/ballot/CreateEmptyBallot.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 16

civitas.common - civitas/common/ballot/RecordOnePairInBallot.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/common/ballotdesign/CalculateBallotLength.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/common/ballotdesign/CalculatePositionInBallot.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/common/ballotdesign/CheckBallotAgainstBallotDesign.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/common/ballotdesign/CreateBallotDesign.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3

civitas.common - civitas/common/ballotdesign/DecomposeBallot.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 25
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 80–81

civitas.common - civitas/common/ballotdesign/GetIndexOfCandidate.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3
CompareObjectsWithEquals Use equals() to compare object references. 7
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 7

civitas.common - civitas/common/ballotdesign/GetNthContext.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.common - civitas/common/ballotdesign/ListContextsNeeded.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.common - civitas/common/ballotdesign/TallyVote.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 18
CyclomaticComplexity The method 'apply(String, ElGamalMsg, String, TallyState, Map<CivitasBigInteger, VoteChoice>)' has a cyclomatic complexity of 14. 26
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 57

civitas.common - civitas/common/board/GetContentCommitmentForBoard.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3

civitas.common - civitas/common/capabilityencryption/EncryptCapability.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.common - civitas/common/election/GetBaseContext.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/common/election/GetBlockName.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.common - civitas/common/election/GetContextForBlock.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.common - civitas/common/election/GetElectionAbandonmentReporter.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3

civitas.common - civitas/common/election/GetVoterBlockForBlock.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.common - civitas/common/election/IsVoterSubmissionInBlock.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/common/electionresults/GetComputerForTeller.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/common/electionresults/GetMetaForTeller.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.common - civitas/common/electoralroll/GetMetaForElectoralRollCapabilityShares.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5

civitas.common - civitas/common/encryptedchoice/EncryptChoice.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.common - civitas/common/mix/AddCommitmentToMix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.common - civitas/common/mix/capabilityelementrevelation/VerifyMixCapabilityElementRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.common - civitas/common/mix/capabilitymix/AddEncryptedCapability.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.common - civitas/common/mix/capabilitymix/GetCapabilityMixMeta.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/common/mix/capabilitymix/GetMixConfirmationMeta.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5

civitas.common - civitas/common/mix/capabilitymix/GetReencryptedCapabilityMix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.common - civitas/common/mix/elementrevelation/VerifyMixElementRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 17

civitas.common - civitas/common/mix/hashrevelation/GetMetaForMixHashRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/common/mix/revelation/GetMixRevelationMeta.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.common - civitas/common/mix/revelation/VerifyMixRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16
CyclomaticComplexity The method 'apply(MixRevelation, ElGamalPublicKey, VoterMix, VoterMix, VoterMix, boolean[])' has a cyclomatic complexity of 10. 23
UnusedAssignment The initializer for variable 'fromIndex' is never used (overwritten on lines 54 and 60) 45
UnusedAssignment The initializer for variable 'toIndex' is never used (overwritten on lines 55 and 61) 46
UnusedAssignment The initializer for variable 'fromMix' is never used (overwritten on lines 52 and 58) 47
UnusedAssignment The initializer for variable 'toMix' is never used (overwritten on lines 53 and 59) 48

civitas.common - civitas/common/mix/voteelementrevelation/VerifyMixVoteElementRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.common - civitas/common/mix/votemix/AddVoteAndCommitmentToVoteMix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/common/mix/votemix/AddVoteToVoteMix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/common/mix/votemix/GetReencryptedVoteFromMix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.common - civitas/common/mix/votemix/GetVoteMixMeta.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.common - civitas/common/tabteller/ConstructTabTellerKeyShareCommitment.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 25

civitas.common - civitas/common/tabteller/voterblockcontents/GetTabTellerVoterBlockContentsMeta.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3

civitas.common - civitas/common/tallystate/CreateTallyState.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5

civitas.common - civitas/common/tallystate/RecordBeat.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/common/verifiablevote/VerifyVerifiableVote.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.common - civitas/common/votercapabilitysharesandproofs/VerifyVoterCapabilitySharesAndProof.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 20
CyclomaticComplexity The method 'apply(VoterCapabilitySharesAndProof, ElGamalSignedCiphertext[], ElGamalPublicKey, ElGamalPublicKey, String, int)' has a cyclomatic complexity of 11. 34
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 51

civitas.common - civitas/common/votersubmission/CheckVoterSubmission.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16
CognitiveComplexity The method 'apply(BallotDesign, VoterSubmission, int, String, CiphertextList, ElGamalPublicKey)' has a cognitive complexity of 15, current threshold is 15 33
CyclomaticComplexity The method 'apply(BallotDesign, VoterSubmission, int, String, CiphertextList, ElGamalPublicKey)' has a cyclomatic complexity of 15. 33

civitas.common - civitas/common/votersubmission/CreateVoterSubmission.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.common - civitas/common/votersubmission/GetMetaForVoterSubmission.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/result/CalculateStrengths.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.common - civitas/result/CalculateWinnerList.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11
LinguisticNaming Linguistics Antipattern - The field 'isFullyIgnored' indicates linguistically it is a boolean, but it is 'IsFullyIgnored' 22
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 34

civitas.common - civitas/result/CompareBeats.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/result/ComputeWinners.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10

civitas.common - civitas/result/FormatResult.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 15
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 17

civitas.common - civitas/result/InitialMatrix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6
CompareObjectsWithEquals Use equals() to compare object references. 14

civitas.common - civitas/result/IsFullyIgnored.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.common - civitas/result/MakeCloudWordList.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 16

civitas.common - civitas/result/Max.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.common - civitas/result/Min.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.common - civitas/result/TransitiveClosure.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.common - civitas/util/CivitasBigIntegerDeserializer.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.common - civitas/util/CivitasBigIntegerSerializer.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/util/GetReaderForFile.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.common - civitas/AppTestConfig.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.common - civitas/WebAppTestConfig.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.common - civitas/bboard/common/VerifyBBPostTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 26

civitas.common - civitas/bboard/server/EndToEndTest.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1–156
SingularField Perhaps 'keys' could be replaced by a local variable. 82
LinguisticNaming Linguistics Antipattern - The getter 'getTestKeys' should not return void linguistically 139
DetachedTestCase Probable detached JUnit test case. 139

civitas.common - civitas/bboard/server/controllers/CloseBoardControllerTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 37
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 44
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 46
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 53
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 98

civitas.common - civitas/bboard/server/controllers/EnvDependentAnswer.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11
AvoidFieldNameMatchingMethodName Field answer has the same name as a method 13

civitas.common - civitas/bboard/server/controllers/PostControllerTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 40
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 102

civitas.common - civitas/common/ballotdesign/DecomposeBallotTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 35

civitas.common - civitas/common/capabilityencryption/EncryptCapabilityStub.java

Rule Violation Line
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 15–16

civitas.common - civitas/common/capabilityencryption/EncryptCapabilityTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 26

civitas.common - civitas/common/election/IsVoterSubmissionInBlockTest.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 21–99
LinguisticNaming Linguistics Antipattern - The field 'isVoterSubmissionInBlock' indicates linguistically it is a boolean, but it is 'IsVoterSubmissionInBlock' 24
AvoidDuplicateLiterals The String literal "(version with context)" appears 4 times in this file; the first occurrence is on line 47 47
AvoidDuplicateLiterals The String literal "(version with encrypted capabilities)" appears 4 times in this file; the first occurrence is on line 74 74

civitas.common - civitas/common/encryptedchoice/EncryptChoiceStub.java

Rule Violation Line
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 17–19

civitas.common - civitas/common/encryptedchoice/EncryptChoiceTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 28

civitas.common - civitas/common/mix/revelation/VerifyMixRevelationTest.java

Rule Violation Line
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 37
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 49
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 62
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 74
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 86
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 98
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 110

civitas.common - civitas/common/mix/voteelementrevelation/VerifyMixVoteElementRevelationTest.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 17–112

civitas.common - civitas/common/mix/votemix/AddVoteAndCommitmentToVoteMixTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 20

civitas.common - civitas/common/votercapabilitysharesandproofs/VerifyVoterCapabilitySharesAndProofTest.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 16–182

civitas.common - civitas/functionaltests/CreatePermutationFunctionalTest.java

Rule Violation Line
AvoidFieldNameMatchingMethodName Field createPermutation has the same name as a method 28
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 32
LinguisticNaming Linguistics Antipattern - The variable 'hasIt' indicates linguistically it is a boolean, but it is 'boolean[]' 35
UnnecessaryBooleanAssertion assertTrue(true) or similar statements are unnecessary 45

civitas.common - civitas/functionaltests/GenerateSafePrimeFunctionalTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 38

civitas.common - civitas/functionaltests/GenerateSchnorrPrimeFunctionalTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 32

civitas.common - civitas/result/ComputeWinnersFunctionalTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 45

civitas.common - civitas/util/ObtainProbablePrimeFunctionalTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 29

civitas.crypto - civitas/bboard/common/BBPost.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 18

civitas.crypto - civitas/bboard/server/Board.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/bboard/server/electioncache/ElectionCache.java

Rule Violation Line
OneClass Multiple classes/records 1–55
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 32

civitas.crypto - civitas/common/ServerHost.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.crypto - civitas/common/VoterDetails.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/VoterEncCapabilityShares.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/ballot/Ballot.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.crypto - civitas/common/board/BoardsForTabulation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/board/BulletinBoardIDish.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3
ShortMethodName Avoid using short method names 6

civitas.crypto - civitas/common/capabilityencryption/VoterEncCapabilities.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/election/ElectionDetails.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 22

civitas.crypto - civitas/common/election/ElectionEvent.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/common/election/ElectionEventFinalize.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.crypto - civitas/common/electoralroll/ElectoralRoll.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/electoralroll/ElectoralRollCapabilities.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/electoralroll/ElectoralRollCapabilityShares.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/mix/VoterMix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/common/mix/capabilityelementrevelation/MixCapabilityElementRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/common/mix/capabilitymix/CapabilityMix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.crypto - civitas/common/mix/elementrevelation/MixElementRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/common/mix/hashrevelation/MixHashRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.crypto - civitas/common/mix/revelation/MixRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/common/mix/voteelementrevelation/MixVoteElementRevelation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/common/mix/votemix/VoteMix.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 17

civitas.crypto - civitas/common/tabteller/distributeddecryptions/TabTellerDistributedDecryptions.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.crypto - civitas/common/tabteller/petcommitments/TabTellerPETShareCommitments.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/tabteller/petsharedecommitments/TabTellerPETShareDecommitments.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/common/tallystate/TallyState.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/tallystatefinal/TallyStateFinal.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/voterapabilityshares/VoterCapabilityShares.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/votercapabilities/VoterCapabilities.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/common/votercapabilitysharesandproofs/VoterCapabilitySharesAndProof.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.crypto - civitas/common/votersubmission/VoterSubmission.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/crypto/algorithms/ConvertHashToBigInt.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/crypto/algorithms/ConvertToBase64.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10

civitas.crypto - civitas/crypto/algorithms/CreateFreshNonce.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/crypto/algorithms/CreateFreshNonceBase64.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.crypto - civitas/crypto/algorithms/CreatePermutation.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10

civitas.crypto - civitas/crypto/algorithms/GenerateRandomInt.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/crypto/ciphertext/ElGamalEncrypt.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/crypto/ciphertext/ElGamalReencrypt.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/ciphertext/MultiplyCiphertexts.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 33

civitas.crypto - civitas/crypto/ciphertextlist/CiphertextList.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.crypto - civitas/crypto/decriptionshare/CombineDecryptionShares.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/crypto/decriptionshare/ConstructElGamalDecryptionShare.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/crypto/decriptionshare/VerifyElGamalDecryptionShare.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.crypto - civitas/crypto/keypair/GenerateElGamalKeyPair.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/keypairshare/GenerateKeyPairShare.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/keyshare/CombineKeyShares.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/keyshare/ConstructElGamalKeyShare.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/keyshare/VerifyElGamalKeyShare.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.crypto - civitas/crypto/msg/DecryptElGamalMessage.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.crypto - civitas/crypto/msg/EncodeMessage.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 34
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 35

civitas.crypto - civitas/crypto/oneoflreencryption/ConstructElGamal1OfLReencryption.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.crypto - civitas/crypto/parameters/CalculateNumberOfPrimeTests.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.crypto - civitas/crypto/parameters/CheckGroup.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.crypto - civitas/crypto/parameters/DecodeChoice.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.crypto - civitas/crypto/parameters/FindGeneratorService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 13
UnusedAssignment The initializer for variable 'g' is never used (overwritten on line 22) 16
UnusedAssignment The initializer for variable 'reject' is never used (overwritten on line 24) 17

civitas.crypto - civitas/crypto/parameters/GenerateElGamalParameters.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10

civitas.crypto - civitas/crypto/parameters/GenerateSafePrime.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.crypto - civitas/crypto/parameters/GenerateSchnorrPrime.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.crypto - civitas/crypto/parameters/LegendreSymbol.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10

civitas.crypto - civitas/crypto/parameters/SetUpDecodeMap.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 14

civitas.crypto - civitas/crypto/parameters/encoder/SafePrimeDecode.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.crypto - civitas/crypto/parameters/encoder/SafePrimeEncode.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.crypto - civitas/crypto/parameters/encoder/SchnorrPrimeDecode.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.crypto - civitas/crypto/parameters/encoder/SchnorrPrimeEncode.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10

civitas.crypto - civitas/crypto/petcommitment/CombinePETShareDecommitments.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/crypto/petcommitment/ConstructPETCommitment.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.crypto - civitas/crypto/petcommitment/IsPetResult.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/crypto/petdecommitment/ConstructPETDecommitment.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/petdecommitment/VerifyPETDecommitment.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.crypto - civitas/crypto/petshare/ConstructPETShare.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.crypto - civitas/crypto/proof1ofl/ConstructElGamalProof1OfL.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 22
CyclomaticComplexity The method 'apply(ElGamalPublicKey, CiphertextList, int, ElGamalCiphertextish, ElGamalReencryptFactor)' has a cyclomatic complexity of 10. 32
NPathComplexity The method 'apply(ElGamalPublicKey, CiphertextList, int, ElGamalCiphertextish, ElGamalReencryptFactor)' has an NPath complexity of 288, current threshold is 200 32

civitas.crypto - civitas/crypto/proof1ofl/ConstructWellKnownCiphertexts.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 19
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 37

civitas.crypto - civitas/crypto/proof1ofl/ElGamalProof1OfL.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/proof1ofl/VerifyElGamal1OfLReencryption.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.crypto - civitas/crypto/proof1ofl/VerifyElGamalProof1OfL.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 20

civitas.crypto - civitas/crypto/proofdisclog/ConstructElGamalDiscLogEqualityProof.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.crypto - civitas/crypto/proofdisclog/VerifyElGamalProofDiscLogEquality.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 19

civitas.crypto - civitas/crypto/proofdvr/ConstructElGamalProofDVR.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 20

civitas.crypto - civitas/crypto/proofdvr/FakeElGamalProofDVR.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 20

civitas.crypto - civitas/crypto/proofdvr/VerifyElGamalProofDVR.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.crypto - civitas/crypto/proofknowndisclog/ConstructProofKnowDiscLog.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/proofknowndisclog/VerifyElGamalProofKnowDiscLog.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 16

civitas.crypto - civitas/crypto/proofvote/CalculateProofEnvironment.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 31

civitas.crypto - civitas/crypto/proofvote/ConstructProofVote.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 17

civitas.crypto - civitas/crypto/proofvote/ProofVote.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/crypto/proofvote/VerifyProofVote.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.crypto - civitas/crypto/publickey/ElGamalPublicKeyisAuthorized.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/crypto/publickey/GetElGamalPublicKeyName.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.crypto - civitas/crypto/publickeyciphertext/EncryptPublic.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 20

civitas.crypto - civitas/crypto/publickeyciphertext/PublicKeyCiphertext.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/reencryptfactor/GenerateElGamalReencryptFactor.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10

civitas.crypto - civitas/crypto/rsakeypair/GenerateKeyPair.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.crypto - civitas/crypto/rsaprivatekey/CreatePrivateKeyFromBytes.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/crypto/rsapublickey/ConvertStringToPublicKey.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 18

civitas.crypto - civitas/crypto/rsapublickey/DecryptPublic.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15

civitas.crypto - civitas/crypto/rsapublickey/IsPublicKeyAuthorized.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.crypto - civitas/crypto/rsapublickey/VerifyPublicKeySignature.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 15
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 26
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 31
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 46

civitas.crypto - civitas/crypto/sharedkey/CreateSharedKeyFromBytes.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.crypto - civitas/crypto/sharedkey/DecryptShared.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/crypto/sharedkey/GenerateSharedKey.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.crypto - civitas/crypto/sharedkey/SharedKeyFromWire.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 11

civitas.crypto - civitas/crypto/sharedkey/SharedKeyToWire.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/crypto/sharedkeyciphertext/EncryptShared.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 14

civitas.crypto - civitas/crypto/sharedkeyciphertext/SharedKeyCiphertext.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/crypto/signature/SignWithPublicKey.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 18
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 29

civitas.crypto - civitas/crypto/signature/Signature.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 17

civitas.crypto - civitas/crypto/signature/VerifyElGamalSignature.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12

civitas.crypto - civitas/crypto/signedciphertext/SignAndEncrypt.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 16

civitas.crypto - civitas/crypto/votecapabilityshare/CombineVoteCapabilityShares.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.crypto - civitas/crypto/votecapabilityshare/GenerateVoteCapabilityShare.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 13

civitas.crypto - civitas/result/CandidateResult.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/result/Winners.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

civitas.crypto - civitas/util/CivitasBigInteger.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12
CyclomaticComplexity The class 'CivitasBigInteger' has a total cyclomatic complexity of 20 (highest 3). 12

civitas.crypto - civitas/util/CivitasBigIntegerFactory.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

civitas.crypto - civitas/util/CivitasBigIntegerInterface.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 7

civitas.crypto - civitas/util/CivitasBigintegerBase.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 5

civitas.crypto - civitas/bboard/common/BBPostTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 17

civitas.crypto - civitas/common/board/BoardClosedContentCommitmentTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 14
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 17

civitas.crypto - civitas/common/electoralroll/ElectoralRollCapabilitySharesTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 12
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 14
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 17

civitas.crypto - civitas/common/mix/capabilitymixrevelation/MixCapabilityElementRevelationTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 18
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 19

civitas.crypto - civitas/common/mix/voteelementrevelation/MixVoteElementRevelationTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 12

civitas.crypto - civitas/common/mix/votemix/VoteMixTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 12
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 13

civitas.crypto - civitas/common/tabteller/TabTellerKeyShareTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 8

civitas.crypto - civitas/crypto/CryptoErrorTest.java

Rule Violation Line
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 10
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 16
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 22

civitas.crypto - civitas/crypto/algorithms/GenerateRandomIntTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 20
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 28
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 36

civitas.crypto - civitas/crypto/ciphertext/MultiplyCiphertextsTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 32

civitas.crypto - civitas/crypto/decriptionshare/ConstructElGamalDecryptionShareTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 24

civitas.crypto - civitas/crypto/decriptionshare/VerifyElGamalDecryptionShareTest.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 16–117
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 32

civitas.crypto - civitas/crypto/keypair/GenerateElGamalKeyPairTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 21

civitas.crypto - civitas/crypto/keypairshare/GenerateKeyPairShareTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 20

civitas.crypto - civitas/crypto/keyshare/CombineKeySharesTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 29

civitas.crypto - civitas/crypto/oneoflreencryption/ConstructElGamal1OfLReencryptionTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 22

civitas.crypto - civitas/crypto/parameters/CheckGroupTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 35
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 43
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 53
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 61
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 69

civitas.crypto - civitas/crypto/parameters/GenerateSafePrimeTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 22

civitas.crypto - civitas/crypto/parameters/GenerateSchnorrPrimeTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 21

civitas.crypto - civitas/crypto/petcommitment/IsPetResultTest.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The field 'isPetResult' indicates linguistically it is a boolean, but it is 'IsPetResult' 17

civitas.crypto - civitas/crypto/petdecommitment/CombinePETShareDecommitmentsTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 24
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 49

civitas.crypto - civitas/crypto/petdecommitment/ConstructPETDecommitmentTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 26

civitas.crypto - civitas/crypto/petdecommitment/VerifyPETDecommitmentTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 35

civitas.crypto - civitas/crypto/proof1ofl/ConstructWellKnownCiphertextsTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 31

civitas.crypto - civitas/crypto/proof1ofl/ElGamalProof1OfLTestData.java

Rule Violation Line
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 52

civitas.crypto - civitas/crypto/proofdvr/ElGamalProofDVRTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 13
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 69

civitas.crypto - civitas/crypto/proofvote/ProofVoteTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 29

civitas.crypto - civitas/crypto/publickeyciphertext/PublicKeyCiphertextTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 4

civitas.crypto - civitas/crypto/publickeymsg/PublicKeyMsgCTest.java

Rule Violation Line
TestClassWithoutTestCases The class 'PublicKeyMsgCTest' might be a test class, but it contains no test cases. 6

civitas.crypto - civitas/crypto/rsaprivatekey/KeySpecMatcher.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.crypto - civitas/crypto/rsaprivatekey/KeySpecMatcherPrivate.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

civitas.crypto - civitas/crypto/rsapublickey/IsPublicKeyAuthorizedTest.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The field 'isPublicKeyAuthorized' indicates linguistically it is a boolean, but it is 'IsPublicKeyAuthorized' 21
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 31

civitas.crypto - civitas/crypto/rsapublickey/VerifyPublicKeySignatureTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 26
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 54
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 67
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 85

civitas.crypto - civitas/crypto/sharedkey/SharedKeyTestData.java

Rule Violation Line
HardCodedCryptoKey Do not use hard coded encryption keys 15
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 15

civitas.crypto - civitas/crypto/sharedkeyciphertext/SharedKeyCiphertextTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 4

civitas.crypto - civitas/crypto/signature/SignWithPublicKeyTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 35
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 63

civitas.crypto - civitas/crypto/signature/SignatureTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 8
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 11
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 14
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 20
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 22
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 24
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 27
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 30

civitas.crypto - civitas/crypto/signature/VerifyElGamalSignatureTest.java

Rule Violation Line
ShortMethodName Avoid using short method names 47

civitas.crypto - civitas/crypto/votecapabilityshare/CombineVoteCapabilitySharesTest.java

Rule Violation Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 21

civitas.externalcrypto - civitas/crypto/CryptoBase.java

Rule Violation Line
ServiceClassField Services have only @Autowired fields 24
ServiceClassField Services have only @Autowired fields 25
ServiceClassField Services have only @Autowired fields 26
AvoidFieldNameMatchingMethodName Field getPublicKeyGenerator has the same name as a method 29
AvoidFieldNameMatchingMethodName Field getSharedKeyGenerator has the same name as a method 32
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 41
ServiceClassMethods Services have only public apply method 46
ServiceClassMethods Services have only public apply method 50
ServiceClassMethods Services have only public apply method 58
ServiceClassMethods Services have only public apply method 62
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 69
ServiceClassMethods Services have only public apply method 74
ServiceClassMethods Services have only public apply method 78
ServiceClassMethods Services have only public apply method 82

civitas.externalcrypto - civitas/crypto/GetPublicKeyGeneratorService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 11
ServiceClassField Services have only @Autowired fields 11
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 24

civitas.externalcrypto - civitas/crypto/GetSharedKeyGeneratorService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 14
ServiceClassField Services have only @Autowired fields 14

civitas.externalcrypto - civitas/crypto/messagedigest/CryptoHash.java

Rule Violation Line
AvoidMessageDigestField You shouldnt declare field of MessageDigest type, because unsynchronized access could cause problems 21
ServiceClassField Services have only @Autowired fields 21

civitas.externalcrypto - civitas/common/ballotdesign/BallotDesignTestData.java

Rule Violation Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 13
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 35

civitas.externalcrypto - civitas/crypto/CryptoBaseTest.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 31–164
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 113
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 123
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 133
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 141
LinguisticNaming Linguistics Antipattern - The variable 'isOne' indicates linguistically it is a boolean, but it is 'int' 152

civitas.externalcrypto - civitas/crypto/messagedigest/MessageDigestTestData.java

Rule Violation Line
AvoidMessageDigestField You shouldnt declare field of MessageDigest type, because unsynchronized access could cause problems 6

civitas.externalcrypto - civitas/crypto/messagedigest/TestUtil.java

Rule Violation Line
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 11

Priority 4

civitas.common - civitas/common/mix/revelation/VerifyMixRevelation.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 29

civitas.common - civitas/result/ComputeWinners.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 15

civitas.common - civitas/result/Max.java

Rule Violation Line
ShortClassName Avoid short class names like Max 7

civitas.common - civitas/result/Min.java

Rule Violation Line
ShortClassName Avoid short class names like Min 7

Files

civitas.base - civitas/common/ballotdesign/BallotDesign.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.base - civitas/crypto/CryptoError.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.base - civitas/crypto/ciphertext/ElGamalCiphertext.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.base - civitas/crypto/ciphertext/ElGamalCiphertextish.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5

civitas.base - civitas/crypto/msg/CryptMessage.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5
ShortMethodName Avoid using short method names 3 6

civitas.base - civitas/crypto/parameters/ElGamalParameters.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.base - civitas/crypto/parameters/PrimePair.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.base - civitas/crypto/publickey/ElGamalPublicKey.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 20

civitas.base - civitas/crypto/signedciphertext/ElGamalSignedCiphertext.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.base - civitas/util/CivitasBigInteger.java

Rule Violation Priority Line
CyclomaticComplexity The class 'CivitasBigInteger' has a total cyclomatic complexity of 20 (highest 3). 3 14

civitas.base - civitas/util/CivitasBigIntegerFactory.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.base - civitas/util/CivitasBigIntegerInterface.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.base - civitas/util/CivitasBigintegerBase.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5

civitas.base - civitas/util/GetCurrentTime.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.base - civitas/util/InitialTests.java

Rule Violation Priority Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 15
UnitTestShouldUseTestAnnotation Unit tests should use the @Test annotation or wont be run. In case of JUnit 5, test methods might use @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest annotations instead. 3 25

civitas.base - civitas/common/ConstructTestData.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 11

civitas.base - civitas/common/RandomAnswer.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9
RedundantFieldInitializer Avoid using redundant field initializer for 'step' 3 10
MutableStaticState Do not use non-final non-private static fields 3 10

civitas.base - civitas/common/RandomAwareTestBase.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7
MutableStaticState Do not use non-final non-private static fields 3 8

civitas.base - civitas/common/RandomFillerAnswer.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.base - civitas/common/TestUtil.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for 'n' 3 11
MutableStaticState Do not use non-final non-private static fields 3 11
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 32
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type Error. 1 33
AssignmentInOperand Avoid assignment to n in operand 3 40

civitas.base - civitas/crypto/ciphertext/ElGamalCiphertextTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 42

civitas.base - civitas/crypto/msg/ElgamalMsgTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 14

civitas.base - civitas/util/BasicValuesTestData.java

Rule Violation Priority Line
UseUnderscoresInNumericLiterals Number 7166760217683588212L should separate every third digit with an underscore 3 16
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 18
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 21
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 84

civitas.base - civitas/util/InitialTestsTest.java

Rule Violation Priority Line
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 12

civitas.base - civitas/util/ReaderAnswer.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12
CloseResource Ensure that resources like this Reader object are closed after use 3 22

civitas.base - civitas/util/XMLAnswer.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.common - civitas/bboard/common/BBPostRepository.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5

civitas.common - civitas/bboard/common/VerifyBBPost.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/bboard/server/BoardRepository.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5

civitas.common - civitas/bboard/server/GetBoardForId.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.common - civitas/bboard/server/RestTemplateResponseErrorHandler.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 28
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type Error. 1 33

civitas.common - civitas/bboard/server/controllers/CloseBoardController.java

Rule Violation Priority Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 58
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 3 70
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 77
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 77

civitas.common - civitas/bboard/server/controllers/CommunicableExceptionHandler.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.common - civitas/bboard/server/controllers/GetRestTemplate.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/bboard/server/controllers/NewBoardController.java

Rule Violation Priority Line
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 33

civitas.common - civitas/bboard/server/controllers/PostController.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1–138
ExceptionAsFlowControl Exception thrown at line 90 is caught in this block. 3 92–94
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 3 93
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 3 115
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 135

civitas.common - civitas/bboard/server/controllers/RetrieveHashController.java

Rule Violation Priority Line
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 3 82

civitas.common - civitas/bboard/server/electioncache/ElectionCacheRepository.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.common - civitas/bboard/server/electioncache/UpdateCache.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.common - civitas/common/CheckAccess.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/common/Configuration.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.common - civitas/common/ConvertFromXml.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.common - civitas/common/ConvertToXml.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.common - civitas/common/GetPrivateKey.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 19
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 24

civitas.common - civitas/common/GetPublicKey.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 18
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 22

civitas.common - civitas/common/LoggerService.java

Rule Violation Priority Line
ServiceClassField Services have only @Autowired fields 3 11

civitas.common - civitas/common/ballot/CreateEmptyBallot.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 3 16

civitas.common - civitas/common/ballot/RecordOnePairInBallot.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/common/ballotdesign/CalculateBallotLength.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/common/ballotdesign/CalculatePositionInBallot.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/common/ballotdesign/CheckBallotAgainstBallotDesign.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/common/ballotdesign/CreateBallotDesign.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 3

civitas.common - civitas/common/ballotdesign/DecomposeBallot.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 25
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 80–81

civitas.common - civitas/common/ballotdesign/GetIndexOfCandidate.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 3
CompareObjectsWithEquals Use equals() to compare object references. 3 7
UseEqualsToCompareStrings Use equals() to compare strings instead of '==' or '!=' 3 7

civitas.common - civitas/common/ballotdesign/GetNthContext.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.common - civitas/common/ballotdesign/ListContextsNeeded.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.common - civitas/common/ballotdesign/TallyVote.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 18
CyclomaticComplexity The method 'apply(String, ElGamalMsg, String, TallyState, Map<CivitasBigInteger, VoteChoice>)' has a cyclomatic complexity of 14. 3 26
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 3 57

civitas.common - civitas/common/board/GetContentCommitmentForBoard.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 3

civitas.common - civitas/common/capabilityencryption/EncryptCapability.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.common - civitas/common/election/GetBaseContext.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/common/election/GetBlockName.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.common - civitas/common/election/GetContextForBlock.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.common - civitas/common/election/GetElectionAbandonmentReporter.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 3

civitas.common - civitas/common/election/GetVoterBlockForBlock.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.common - civitas/common/election/IsVoterSubmissionInBlock.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/common/electionresults/GetComputerForTeller.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/common/electionresults/GetMetaForTeller.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.common - civitas/common/electoralroll/GetMetaForElectoralRollCapabilityShares.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5

civitas.common - civitas/common/encryptedchoice/EncryptChoice.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.common - civitas/common/mix/AddCommitmentToMix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.common - civitas/common/mix/capabilityelementrevelation/VerifyMixCapabilityElementRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.common - civitas/common/mix/capabilitymix/AddEncryptedCapability.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.common - civitas/common/mix/capabilitymix/GetCapabilityMixMeta.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/common/mix/capabilitymix/GetMixConfirmationMeta.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5

civitas.common - civitas/common/mix/capabilitymix/GetReencryptedCapabilityMix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.common - civitas/common/mix/elementrevelation/VerifyMixElementRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 17
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 36

civitas.common - civitas/common/mix/hashrevelation/GetMetaForMixHashRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/common/mix/revelation/GetMixRevelationMeta.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 23

civitas.common - civitas/common/mix/revelation/VerifyMixRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16
CyclomaticComplexity The method 'apply(MixRevelation, ElGamalPublicKey, VoterMix, VoterMix, VoterMix, boolean[])' has a cyclomatic complexity of 10. 3 23
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 29
UnusedAssignment The initializer for variable 'fromIndex' is never used (overwritten on lines 54 and 60) 3 45
UnusedAssignment The initializer for variable 'toIndex' is never used (overwritten on lines 55 and 61) 3 46
UnusedAssignment The initializer for variable 'fromMix' is never used (overwritten on lines 52 and 58) 3 47
UnusedAssignment The initializer for variable 'toMix' is never used (overwritten on lines 53 and 59) 3 48

civitas.common - civitas/common/mix/voteelementrevelation/VerifyMixVoteElementRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 28

civitas.common - civitas/common/mix/votemix/AddVoteAndCommitmentToVoteMix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 20

civitas.common - civitas/common/mix/votemix/AddVoteToVoteMix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/common/mix/votemix/GetReencryptedVoteFromMix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 25

civitas.common - civitas/common/mix/votemix/GetVoteMixMeta.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 20

civitas.common - civitas/common/tabteller/ConstructTabTellerKeyShareCommitment.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 25

civitas.common - civitas/common/tabteller/voterblockcontents/GetTabTellerVoterBlockContentsMeta.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 3

civitas.common - civitas/common/tallystate/CreateTallyState.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5

civitas.common - civitas/common/tallystate/RecordBeat.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/common/verifiablevote/VerifyVerifiableVote.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.common - civitas/common/votercapabilitysharesandproofs/VerifyVoterCapabilitySharesAndProof.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 20
CyclomaticComplexity The method 'apply(VoterCapabilitySharesAndProof, ElGamalSignedCiphertext[], ElGamalPublicKey, ElGamalPublicKey, String, int)' has a cyclomatic complexity of 11. 3 34
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 42
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 51

civitas.common - civitas/common/votersubmission/CheckVoterSubmission.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16
CognitiveComplexity The method 'apply(BallotDesign, VoterSubmission, int, String, CiphertextList, ElGamalPublicKey)' has a cognitive complexity of 15, current threshold is 15 3 33
CyclomaticComplexity The method 'apply(BallotDesign, VoterSubmission, int, String, CiphertextList, ElGamalPublicKey)' has a cyclomatic complexity of 15. 3 33

civitas.common - civitas/common/votersubmission/CreateVoterSubmission.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.common - civitas/common/votersubmission/GetMetaForVoterSubmission.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/result/CalculateStrengths.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.common - civitas/result/CalculateWinnerList.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11
LinguisticNaming Linguistics Antipattern - The field 'isFullyIgnored' indicates linguistically it is a boolean, but it is 'IsFullyIgnored' 3 22
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 34

civitas.common - civitas/result/CompareBeats.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/result/ComputeWinners.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 15

civitas.common - civitas/result/FormatResult.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 15
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 17

civitas.common - civitas/result/InitialMatrix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6
CompareObjectsWithEquals Use equals() to compare object references. 3 14

civitas.common - civitas/result/IsFullyIgnored.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.common - civitas/result/MakeCloudWordList.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 16

civitas.common - civitas/result/Max.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Max 4 7
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.common - civitas/result/Min.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Min 4 7
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.common - civitas/result/TransitiveClosure.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.common - civitas/util/CivitasBigIntegerDeserializer.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.common - civitas/util/CivitasBigIntegerSerializer.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/util/GetReaderForFile.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.common - civitas/AppTestConfig.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.common - civitas/WebAppTestConfig.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.common - civitas/bboard/common/VerifyBBPostTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 26

civitas.common - civitas/bboard/server/EndToEndTest.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1–156
SingularField Perhaps 'keys' could be replaced by a local variable. 3 82
LinguisticNaming Linguistics Antipattern - The getter 'getTestKeys' should not return void linguistically 3 139
DetachedTestCase Probable detached JUnit test case. 3 139

civitas.common - civitas/bboard/server/controllers/CloseBoardControllerTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 37
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 44
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 46
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 53
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 98

civitas.common - civitas/bboard/server/controllers/EnvDependentAnswer.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11
AvoidFieldNameMatchingMethodName Field answer has the same name as a method 3 13

civitas.common - civitas/bboard/server/controllers/PostControllerTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 40
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 102

civitas.common - civitas/common/ballotdesign/DecomposeBallotTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 35

civitas.common - civitas/common/capabilityencryption/EncryptCapabilityStub.java

Rule Violation Priority Line
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 15–16

civitas.common - civitas/common/capabilityencryption/EncryptCapabilityTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 26

civitas.common - civitas/common/election/IsVoterSubmissionInBlockTest.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 21–99
LinguisticNaming Linguistics Antipattern - The field 'isVoterSubmissionInBlock' indicates linguistically it is a boolean, but it is 'IsVoterSubmissionInBlock' 3 24
AvoidDuplicateLiterals The String literal "(version with context)" appears 4 times in this file; the first occurrence is on line 47 3 47
AvoidDuplicateLiterals The String literal "(version with encrypted capabilities)" appears 4 times in this file; the first occurrence is on line 74 3 74

civitas.common - civitas/common/encryptedchoice/EncryptChoiceStub.java

Rule Violation Priority Line
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 17–19

civitas.common - civitas/common/encryptedchoice/EncryptChoiceTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 28

civitas.common - civitas/common/mix/revelation/VerifyMixRevelationTest.java

Rule Violation Priority Line
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 37
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 49
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 62
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 74
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 86
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 98
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 110

civitas.common - civitas/common/mix/voteelementrevelation/VerifyMixVoteElementRevelationTest.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 17–112

civitas.common - civitas/common/mix/votemix/AddVoteAndCommitmentToVoteMixTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 20

civitas.common - civitas/common/votercapabilitysharesandproofs/VerifyVoterCapabilitySharesAndProofTest.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 16–182

civitas.common - civitas/functionaltests/CreatePermutationFunctionalTest.java

Rule Violation Priority Line
AvoidFieldNameMatchingMethodName Field createPermutation has the same name as a method 3 28
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 32
LinguisticNaming Linguistics Antipattern - The variable 'hasIt' indicates linguistically it is a boolean, but it is 'boolean[]' 3 35
UnnecessaryBooleanAssertion assertTrue(true) or similar statements are unnecessary 3 45

civitas.common - civitas/functionaltests/GenerateSafePrimeFunctionalTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 38

civitas.common - civitas/functionaltests/GenerateSchnorrPrimeFunctionalTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 32

civitas.common - civitas/result/ComputeWinnersFunctionalTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 45

civitas.common - civitas/util/ObtainProbablePrimeFunctionalTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 29

civitas.crypto - civitas/bboard/common/BBPost.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 18

civitas.crypto - civitas/bboard/server/Board.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/bboard/server/electioncache/ElectionCache.java

Rule Violation Priority Line
OneClass Multiple classes/records 3 1–55
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 32

civitas.crypto - civitas/common/ServerHost.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.crypto - civitas/common/VoterDetails.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/VoterEncCapabilityShares.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/ballot/Ballot.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.crypto - civitas/common/board/BoardsForTabulation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/board/BulletinBoardIDish.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 3
ShortMethodName Avoid using short method names 3 6

civitas.crypto - civitas/common/capabilityencryption/VoterEncCapabilities.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/election/ElectionDetails.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 22

civitas.crypto - civitas/common/election/ElectionEvent.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/common/election/ElectionEventFinalize.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.crypto - civitas/common/electoralroll/ElectoralRoll.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/electoralroll/ElectoralRollCapabilities.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/electoralroll/ElectoralRollCapabilityShares.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/mix/VoterMix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/common/mix/capabilityelementrevelation/MixCapabilityElementRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/common/mix/capabilitymix/CapabilityMix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.crypto - civitas/common/mix/elementrevelation/MixElementRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/common/mix/hashrevelation/MixHashRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.crypto - civitas/common/mix/revelation/MixRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/common/mix/voteelementrevelation/MixVoteElementRevelation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/common/mix/votemix/VoteMix.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 17

civitas.crypto - civitas/common/tabteller/distributeddecryptions/TabTellerDistributedDecryptions.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.crypto - civitas/common/tabteller/petcommitments/TabTellerPETShareCommitments.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/tabteller/petsharedecommitments/TabTellerPETShareDecommitments.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/common/tallystate/TallyState.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/tallystatefinal/TallyStateFinal.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/voterapabilityshares/VoterCapabilityShares.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/votercapabilities/VoterCapabilities.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/common/votercapabilitysharesandproofs/VoterCapabilitySharesAndProof.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.crypto - civitas/common/votersubmission/VoterSubmission.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/crypto/algorithms/ConvertHashToBigInt.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/crypto/algorithms/ConvertToBase64.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10

civitas.crypto - civitas/crypto/algorithms/CreateFreshNonce.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/crypto/algorithms/CreateFreshNonceBase64.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.crypto - civitas/crypto/algorithms/CreatePermutation.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10

civitas.crypto - civitas/crypto/algorithms/GenerateRandomInt.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/crypto/ciphertext/ElGamalEncrypt.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/crypto/ciphertext/ElGamalReencrypt.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/ciphertext/MultiplyCiphertexts.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 33

civitas.crypto - civitas/crypto/ciphertextlist/CiphertextList.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.crypto - civitas/crypto/decriptionshare/CombineDecryptionShares.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/crypto/decriptionshare/ConstructElGamalDecryptionShare.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/crypto/decriptionshare/VerifyElGamalDecryptionShare.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.crypto - civitas/crypto/keypair/GenerateElGamalKeyPair.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/keypairshare/GenerateKeyPairShare.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/keyshare/CombineKeyShares.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/keyshare/ConstructElGamalKeyShare.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/keyshare/VerifyElGamalKeyShare.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.crypto - civitas/crypto/msg/DecryptElGamalMessage.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.crypto - civitas/crypto/msg/EncodeMessage.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 34
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 3 35

civitas.crypto - civitas/crypto/oneoflreencryption/ConstructElGamal1OfLReencryption.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.crypto - civitas/crypto/parameters/CalculateNumberOfPrimeTests.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.crypto - civitas/crypto/parameters/CheckGroup.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.crypto - civitas/crypto/parameters/DecodeChoice.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.crypto - civitas/crypto/parameters/FindGeneratorService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 13
UnusedAssignment The initializer for variable 'g' is never used (overwritten on line 22) 3 16
UnusedAssignment The initializer for variable 'reject' is never used (overwritten on line 24) 3 17

civitas.crypto - civitas/crypto/parameters/GenerateElGamalParameters.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10

civitas.crypto - civitas/crypto/parameters/GenerateSafePrime.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.crypto - civitas/crypto/parameters/GenerateSchnorrPrime.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.crypto - civitas/crypto/parameters/LegendreSymbol.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10

civitas.crypto - civitas/crypto/parameters/SetUpDecodeMap.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 14

civitas.crypto - civitas/crypto/parameters/encoder/SafePrimeDecode.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7
AvoidReassigningParameters Avoid reassigning parameters such as 'i' 2 14

civitas.crypto - civitas/crypto/parameters/encoder/SafePrimeEncode.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.crypto - civitas/crypto/parameters/encoder/SchnorrPrimeDecode.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.crypto - civitas/crypto/parameters/encoder/SchnorrPrimeEncode.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10

civitas.crypto - civitas/crypto/petcommitment/CombinePETShareDecommitments.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9
AvoidReassigningParameters Avoid reassigning parameters such as 'd' 2 17

civitas.crypto - civitas/crypto/petcommitment/ConstructPETCommitment.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.crypto - civitas/crypto/petcommitment/IsPetResult.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/crypto/petdecommitment/ConstructPETDecommitment.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/petdecommitment/VerifyPETDecommitment.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.crypto - civitas/crypto/petshare/ConstructPETShare.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.crypto - civitas/crypto/proof1ofl/ConstructElGamalProof1OfL.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 22
CyclomaticComplexity The method 'apply(ElGamalPublicKey, CiphertextList, int, ElGamalCiphertextish, ElGamalReencryptFactor)' has a cyclomatic complexity of 10. 3 32
NPathComplexity The method 'apply(ElGamalPublicKey, CiphertextList, int, ElGamalCiphertextish, ElGamalReencryptFactor)' has an NPath complexity of 288, current threshold is 200 3 32

civitas.crypto - civitas/crypto/proof1ofl/ConstructWellKnownCiphertexts.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 19
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 37

civitas.crypto - civitas/crypto/proof1ofl/ElGamalProof1OfL.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/proof1ofl/VerifyElGamal1OfLReencryption.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.crypto - civitas/crypto/proof1ofl/VerifyElGamalProof1OfL.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 20

civitas.crypto - civitas/crypto/proofdisclog/ConstructElGamalDiscLogEqualityProof.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.crypto - civitas/crypto/proofdisclog/VerifyElGamalProofDiscLogEquality.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 19

civitas.crypto - civitas/crypto/proofdvr/ConstructElGamalProofDVR.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 20

civitas.crypto - civitas/crypto/proofdvr/FakeElGamalProofDVR.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 20

civitas.crypto - civitas/crypto/proofdvr/VerifyElGamalProofDVR.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.crypto - civitas/crypto/proofknowndisclog/ConstructProofKnowDiscLog.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/proofknowndisclog/VerifyElGamalProofKnowDiscLog.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 16

civitas.crypto - civitas/crypto/proofvote/CalculateProofEnvironment.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 31

civitas.crypto - civitas/crypto/proofvote/ConstructProofVote.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 17

civitas.crypto - civitas/crypto/proofvote/ProofVote.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/crypto/proofvote/VerifyProofVote.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.crypto - civitas/crypto/publickey/ElGamalPublicKeyisAuthorized.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/crypto/publickey/GetElGamalPublicKeyName.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.crypto - civitas/crypto/publickeyciphertext/EncryptPublic.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 20

civitas.crypto - civitas/crypto/publickeyciphertext/PublicKeyCiphertext.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/reencryptfactor/GenerateElGamalReencryptFactor.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10

civitas.crypto - civitas/crypto/rsakeypair/GenerateKeyPair.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.crypto - civitas/crypto/rsaprivatekey/CreatePrivateKeyFromBytes.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/crypto/rsapublickey/ConvertStringToPublicKey.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 18

civitas.crypto - civitas/crypto/rsapublickey/DecryptPublic.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15

civitas.crypto - civitas/crypto/rsapublickey/IsPublicKeyAuthorized.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.crypto - civitas/crypto/rsapublickey/VerifyPublicKeySignature.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 15
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 26
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 31
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 46

civitas.crypto - civitas/crypto/sharedkey/CreateSharedKeyFromBytes.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.crypto - civitas/crypto/sharedkey/DecryptShared.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/crypto/sharedkey/GenerateSharedKey.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.crypto - civitas/crypto/sharedkey/SharedKeyFromWire.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 11

civitas.crypto - civitas/crypto/sharedkey/SharedKeyToWire.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/crypto/sharedkeyciphertext/EncryptShared.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 14

civitas.crypto - civitas/crypto/sharedkeyciphertext/SharedKeyCiphertext.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/crypto/signature/SignWithPublicKey.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 18
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 29

civitas.crypto - civitas/crypto/signature/Signature.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 17

civitas.crypto - civitas/crypto/signature/VerifyElGamalSignature.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12

civitas.crypto - civitas/crypto/signedciphertext/SignAndEncrypt.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 16

civitas.crypto - civitas/crypto/votecapabilityshare/CombineVoteCapabilityShares.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.crypto - civitas/crypto/votecapabilityshare/GenerateVoteCapabilityShare.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 13

civitas.crypto - civitas/result/CandidateResult.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/result/Winners.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

civitas.crypto - civitas/util/CivitasBigInteger.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12
CyclomaticComplexity The class 'CivitasBigInteger' has a total cyclomatic complexity of 20 (highest 3). 3 12

civitas.crypto - civitas/util/CivitasBigIntegerFactory.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

civitas.crypto - civitas/util/CivitasBigIntegerInterface.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 7

civitas.crypto - civitas/util/CivitasBigintegerBase.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 5

civitas.crypto - civitas/bboard/common/BBPostTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 17

civitas.crypto - civitas/common/board/BoardClosedContentCommitmentTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 14
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 17

civitas.crypto - civitas/common/electoralroll/ElectoralRollCapabilitySharesTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 12
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 14
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 17

civitas.crypto - civitas/common/mix/capabilitymixrevelation/MixCapabilityElementRevelationTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 18
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 19

civitas.crypto - civitas/common/mix/voteelementrevelation/MixVoteElementRevelationTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 12

civitas.crypto - civitas/common/mix/votemix/VoteMixTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 12
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 13

civitas.crypto - civitas/common/tabteller/TabTellerKeyShareTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 8

civitas.crypto - civitas/crypto/CryptoErrorTest.java

Rule Violation Priority Line
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 10
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 16
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 22

civitas.crypto - civitas/crypto/algorithms/GenerateRandomIntTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 20
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 28
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 36

civitas.crypto - civitas/crypto/ciphertext/MultiplyCiphertextsTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 32

civitas.crypto - civitas/crypto/decriptionshare/ConstructElGamalDecryptionShareTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 24

civitas.crypto - civitas/crypto/decriptionshare/VerifyElGamalDecryptionShareTest.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 16–117
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 32

civitas.crypto - civitas/crypto/keypair/GenerateElGamalKeyPairTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 21

civitas.crypto - civitas/crypto/keypairshare/GenerateKeyPairShareTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 20

civitas.crypto - civitas/crypto/keyshare/CombineKeySharesTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 29

civitas.crypto - civitas/crypto/oneoflreencryption/ConstructElGamal1OfLReencryptionTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 22

civitas.crypto - civitas/crypto/parameters/CheckGroupTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 35
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 43
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 53
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 61
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 69

civitas.crypto - civitas/crypto/parameters/GenerateSafePrimeTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 22

civitas.crypto - civitas/crypto/parameters/GenerateSchnorrPrimeTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 21

civitas.crypto - civitas/crypto/petcommitment/IsPetResultTest.java

Rule Violation Priority Line
LinguisticNaming Linguistics Antipattern - The field 'isPetResult' indicates linguistically it is a boolean, but it is 'IsPetResult' 3 17

civitas.crypto - civitas/crypto/petdecommitment/CombinePETShareDecommitmentsTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 24
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 49

civitas.crypto - civitas/crypto/petdecommitment/ConstructPETDecommitmentTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 26

civitas.crypto - civitas/crypto/petdecommitment/VerifyPETDecommitmentTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 35

civitas.crypto - civitas/crypto/proof1ofl/ConstructWellKnownCiphertextsTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 31

civitas.crypto - civitas/crypto/proof1ofl/ElGamalProof1OfLTestData.java

Rule Violation Priority Line
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 52

civitas.crypto - civitas/crypto/proofdvr/ElGamalProofDVRTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 13
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 69

civitas.crypto - civitas/crypto/proofvote/ProofVoteTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 29

civitas.crypto - civitas/crypto/publickeyciphertext/PublicKeyCiphertextTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 4

civitas.crypto - civitas/crypto/publickeymsg/PublicKeyMsgCTest.java

Rule Violation Priority Line
TestClassWithoutTestCases The class 'PublicKeyMsgCTest' might be a test class, but it contains no test cases. 3 6

civitas.crypto - civitas/crypto/rsaprivatekey/KeySpecMatcher.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.crypto - civitas/crypto/rsaprivatekey/KeySpecMatcherPrivate.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

civitas.crypto - civitas/crypto/rsapublickey/IsPublicKeyAuthorizedTest.java

Rule Violation Priority Line
LinguisticNaming Linguistics Antipattern - The field 'isPublicKeyAuthorized' indicates linguistically it is a boolean, but it is 'IsPublicKeyAuthorized' 3 21
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 31

civitas.crypto - civitas/crypto/rsapublickey/VerifyPublicKeySignatureTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 26
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 54
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 67
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 85

civitas.crypto - civitas/crypto/sharedkey/SharedKeyTestData.java

Rule Violation Priority Line
HardCodedCryptoKey Do not use hard coded encryption keys 3 15
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 15

civitas.crypto - civitas/crypto/sharedkeyciphertext/SharedKeyCiphertextTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 4

civitas.crypto - civitas/crypto/signature/SignWithPublicKeyTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 35
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 63

civitas.crypto - civitas/crypto/signature/SignatureTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 8
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 11
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 14
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 20
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 22
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 24
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 27
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 30

civitas.crypto - civitas/crypto/signature/VerifyElGamalSignatureTest.java

Rule Violation Priority Line
ShortMethodName Avoid using short method names 3 47

civitas.crypto - civitas/crypto/votecapabilityshare/CombineVoteCapabilitySharesTest.java

Rule Violation Priority Line
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 21

civitas.externalcrypto - civitas/crypto/CryptoBase.java

Rule Violation Priority Line
ServiceClassField Services have only @Autowired fields 3 24
ServiceClassField Services have only @Autowired fields 3 25
ServiceClassField Services have only @Autowired fields 3 26
AvoidFieldNameMatchingMethodName Field getPublicKeyGenerator has the same name as a method 3 29
AvoidFieldNameMatchingMethodName Field getSharedKeyGenerator has the same name as a method 3 32
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 41
ServiceClassMethods Services have only public apply method 3 46
ServiceClassMethods Services have only public apply method 3 50
ServiceClassMethods Services have only public apply method 3 58
ServiceClassMethods Services have only public apply method 3 62
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 69
ServiceClassMethods Services have only public apply method 3 74
ServiceClassMethods Services have only public apply method 3 78
ServiceClassMethods Services have only public apply method 3 82

civitas.externalcrypto - civitas/crypto/GetPublicKeyGeneratorService.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 11
ServiceClassField Services have only @Autowired fields 3 11
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 24

civitas.externalcrypto - civitas/crypto/GetSharedKeyGeneratorService.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 14
ServiceClassField Services have only @Autowired fields 3 14

civitas.externalcrypto - civitas/crypto/messagedigest/CryptoHash.java

Rule Violation Priority Line
AvoidMessageDigestField You shouldnt declare field of MessageDigest type, because unsynchronized access could cause problems 3 21
ServiceClassField Services have only @Autowired fields 3 21

civitas.externalcrypto - civitas/common/ballotdesign/BallotDesignTestData.java

Rule Violation Priority Line
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 13
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 35

civitas.externalcrypto - civitas/crypto/CryptoBaseTest.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 31–164
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 113
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 123
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 133
UnitTestShouldIncludeAssert This unit test should include assert() or fail() 3 141
LinguisticNaming Linguistics Antipattern - The variable 'isOne' indicates linguistically it is a boolean, but it is 'int' 3 152

civitas.externalcrypto - civitas/crypto/messagedigest/MessageDigestTestData.java

Rule Violation Priority Line
AvoidMessageDigestField You shouldnt declare field of MessageDigest type, because unsynchronized access could cause problems 3 6

civitas.externalcrypto - civitas/crypto/messagedigest/TestUtil.java

Rule Violation Priority Line
PreserveStackTrace Thrown exception does not preserve the stack trace of exception 'e' on all code paths 3 11
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type Error. 1 11