PMD Results
The following document contains the results of PMD 7.17.0.
Violations By Priority
Priority 1
civitas/bboard/server/RestTemplateResponseErrorHandler.java
civitas/bboard/server/controllers/CloseBoardController.java
civitas/common/mix/elementrevelation/VerifyMixElementRevelation.java
civitas/common/mix/revelation/GetMixRevelationMeta.java
civitas/common/mix/voteelementrevelation/VerifyMixVoteElementRevelation.java
civitas/common/mix/votemix/AddVoteAndCommitmentToVoteMix.java
civitas/common/mix/votemix/GetReencryptedVoteFromMix.java
civitas/common/mix/votemix/GetVoteMixMeta.java
civitas/common/votercapabilitysharesandproofs/VerifyVoterCapabilitySharesAndProof.java
Priority 3
civitas/bboard/common/BBPostRepository.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
5 |
civitas/bboard/common/VerifyBBPost.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
20 |
civitas/bboard/server/BoardRepository.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
5 |
civitas/bboard/server/GetBoardForId.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
9 |
civitas/bboard/server/RestTemplateResponseErrorHandler.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
13 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
25 |
civitas/bboard/server/controllers/CloseBoardController.java
civitas/bboard/server/controllers/CommunicableException.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
civitas/bboard/server/controllers/CommunicableExceptionHandler.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
12 |
civitas/bboard/server/controllers/GetRestTemplate.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/bboard/server/controllers/NewBoardController.java
civitas/bboard/server/controllers/PostController.java
| Rule |
Violation |
Line |
| ExcessiveImports |
A high number of imports can indicate a high degree of coupling within an object. |
1–138 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
89 |
| PreserveStackTrace |
Thrown exception does not preserve the stack trace of exception 'e' on all code paths |
93 |
| PreserveStackTrace |
Thrown exception does not preserve the stack trace of exception 'e' on all code paths |
115 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
135 |
civitas/bboard/server/controllers/RetrieveHashController.java
| Rule |
Violation |
Line |
| UnusedPrivateMethod |
Avoid unused private methods such as 'apply(String, Long, Long, String)'. |
51 |
| PreserveStackTrace |
Thrown exception does not preserve the stack trace of exception 'e' on all code paths |
82 |
civitas/bboard/server/controllers/RetrievePostsController.java
| Rule |
Violation |
Line |
| UnusedPrivateMethod |
Avoid unused private methods such as 'apply(String)'. |
23 |
civitas/bboard/server/electioncache/ElectionCacheRepository.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
7 |
civitas/bboard/server/electioncache/UpdateCache.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
15 |
civitas/common/CheckAccess.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/common/Configuration.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
7 |
civitas/common/ConvertFromXml.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
15 |
civitas/common/ConvertToXml.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
12 |
civitas/common/GetPrivateKey.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
19 |
| UseConcurrentHashMap |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
24 |
civitas/common/GetPublicKey.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
18 |
| UseConcurrentHashMap |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
22 |
civitas/common/LoggerService.java
| Rule |
Violation |
Line |
| ServiceClassField |
Services have only @Autowired fields |
11 |
civitas/common/ballot/CreateEmptyBallot.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
10 |
| AvoidLiteralsInIfCondition |
Avoid using literals such as 2 in if statements |
16 |
civitas/common/ballot/RecordOnePairInBallot.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/common/ballotdesign/CalculateBallotLength.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/common/ballotdesign/CalculatePositionInBallot.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/common/ballotdesign/CheckBallotAgainstBallotDesign.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/common/ballotdesign/CreateBallotDesign.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
civitas/common/ballotdesign/DecomposeBallot.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
25 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
50 |
| AvoidInstantiatingObjectsInLoops |
Avoid instantiating new objects inside loops |
80–81 |
civitas/common/ballotdesign/GetIndexOfCandidate.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
| CompareObjectsWithEquals |
Use equals() to compare object references. |
7 |
| UseEqualsToCompareStrings |
Use equals() to compare strings instead of '==' or '!=' |
7 |
civitas/common/ballotdesign/GetNthContext.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
8 |
civitas/common/ballotdesign/ListContextsNeeded.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
8 |
civitas/common/ballotdesign/TallyVote.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
18 |
| CyclomaticComplexity |
The method 'apply(String, ElGamalMsg, String, TallyState, Map<CivitasBigInteger, VoteChoice>)' has a cyclomatic complexity of 14. |
26 |
| PreserveStackTrace |
Thrown exception does not preserve the stack trace of exception 'e' on all code paths |
57 |
civitas/common/board/GetContentCommitmentForBoard.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
civitas/common/capabilityencryption/EncryptCapability.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
16 |
civitas/common/election/GetBaseContext.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/common/election/GetBlockName.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
9 |
civitas/common/election/GetContextForBlock.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
9 |
civitas/common/election/GetElectionAbandonmentReporter.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
civitas/common/election/GetVoterBlockForBlock.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
9 |
civitas/common/election/IsVoterSubmissionInBlock.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/common/electionresults/GetComputerForTeller.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/common/electionresults/GetMetaForTeller.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
9 |
civitas/common/electoralroll/GetMetaForElectoralRollCapabilityShares.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
5 |
civitas/common/encryptedchoice/EncryptChoice.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
15 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
24 |
civitas/common/mix/AddCommitmentToMix.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
8 |
civitas/common/mix/capabilityelementrevelation/VerifyMixCapabilityElementRevelation.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
13 |
civitas/common/mix/capabilitymix/AddEncryptedCapability.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
7 |
civitas/common/mix/capabilitymix/GetCapabilityMixMeta.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/common/mix/capabilitymix/GetMixConfirmationMeta.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
5 |
civitas/common/mix/capabilitymix/GetReencryptedCapabilityMix.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
12 |
civitas/common/mix/elementrevelation/VerifyMixElementRevelation.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
18 |
civitas/common/mix/hashrevelation/GetMetaForMixHashRevelation.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/common/mix/revelation/GetMixRevelationMeta.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
12 |
civitas/common/mix/revelation/VerifyMixRevelation.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
16 |
| CyclomaticComplexity |
The method 'apply(MixRevelation, ElGamalPublicKey, VoterMix, VoterMix, VoterMix, boolean[])' has a cyclomatic complexity of 10. |
23 |
| UnusedAssignment |
The initializer for variable 'fromIndex' is never used (overwritten on lines 54 and 60) |
45 |
| UnusedAssignment |
The initializer for variable 'toIndex' is never used (overwritten on lines 55 and 61) |
46 |
| UnusedAssignment |
The initializer for variable 'fromMix' is never used (overwritten on lines 52 and 58) |
47 |
| UnusedAssignment |
The initializer for variable 'toMix' is never used (overwritten on lines 53 and 59) |
48 |
civitas/common/mix/voteelementrevelation/VerifyMixVoteElementRevelation.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
15 |
civitas/common/mix/votemix/AddVoteAndCommitmentToVoteMix.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/common/mix/votemix/AddVoteToVoteMix.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/common/mix/votemix/GetReencryptedVoteFromMix.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
13 |
civitas/common/mix/votemix/GetVoteMixMeta.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
12 |
civitas/common/tabteller/ConstructTabTellerKeyShareCommitment.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
15 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
28 |
civitas/common/tabteller/voterblockcontents/GetTabTellerVoterBlockContentsMeta.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
civitas/common/tallystate/CreateTallyState.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
5 |
civitas/common/tallystate/RecordBeat.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/common/verifiablevote/VerifyVerifiableVote.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
12 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
20 |
civitas/common/votercapabilitysharesandproofs/VerifyVoterCapabilitySharesAndProof.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
22 |
| CyclomaticComplexity |
The method 'apply(VoterCapabilitySharesAndProof, ElGamalSignedCiphertext[], ElGamalPublicKey, ElGamalPublicKey, String, int)' has a cyclomatic complexity of 11. |
36 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
54 |
civitas/common/votersubmission/CheckVoterSubmission.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
16 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
28 |
| CognitiveComplexity |
The method 'apply(BallotDesign, VoterSubmission, int, String, CiphertextList, ElGamalPublicKey)' has a cognitive complexity of 15, current threshold is 15 |
33 |
| CyclomaticComplexity |
The method 'apply(BallotDesign, VoterSubmission, int, String, CiphertextList, ElGamalPublicKey)' has a cyclomatic complexity of 15. |
33 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
38 |
civitas/common/votersubmission/CreateVoterSubmission.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
8 |
civitas/common/votersubmission/GetMetaForVoterSubmission.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/result/CalculateStrengths.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
8 |
civitas/result/CalculateWinnerList.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
| LinguisticNaming |
Linguistics Antipattern - The field 'isFullyIgnored' indicates linguistically it is a boolean, but it is 'IsFullyIgnored' |
22 |
| AvoidInstantiatingObjectsInLoops |
Avoid instantiating new objects inside loops |
34 |
civitas/result/CompareBeats.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/result/ComputeWinners.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
10 |
civitas/result/FormatResult.java
civitas/result/InitialMatrix.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
| CompareObjectsWithEquals |
Use equals() to compare object references. |
15 |
civitas/result/IsFullyIgnored.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
6 |
civitas/result/MakeCloudWordList.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
9 |
| AvoidInstantiatingObjectsInLoops |
Avoid instantiating new objects inside loops |
17 |
civitas/result/Max.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
7 |
civitas/result/Min.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
7 |
civitas/result/TransitiveClosure.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
7 |
civitas/util/CivitasBigIntegerDeserializer.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
13 |
civitas/util/CivitasBigIntegerSerializer.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
civitas/util/GetReaderForFile.java
| Rule |
Violation |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
11 |
Priority 4
civitas/common/mix/revelation/VerifyMixRevelation.java
| Rule |
Violation |
Line |
| UseVarargs |
Consider using varargs for methods or constructors which take an array the last parameter. |
29 |
civitas/result/ComputeWinners.java
| Rule |
Violation |
Line |
| UseVarargs |
Consider using varargs for methods or constructors which take an array the last parameter. |
15 |
Files
civitas/bboard/common/BBPostRepository.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
5 |
civitas/bboard/common/VerifyBBPost.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
3 |
20 |
civitas/bboard/server/BoardRepository.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
5 |
civitas/bboard/server/GetBoardForId.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
9 |
civitas/bboard/server/RestTemplateResponseErrorHandler.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
13 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
3 |
25 |
| AvoidThrowingRawExceptionTypes |
Avoid throwing raw exception type Error. |
1 |
30 |
civitas/bboard/server/controllers/CloseBoardController.java
civitas/bboard/server/controllers/CommunicableException.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
3 |
civitas/bboard/server/controllers/CommunicableExceptionHandler.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
12 |
civitas/bboard/server/controllers/GetRestTemplate.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
civitas/bboard/server/controllers/NewBoardController.java
civitas/bboard/server/controllers/PostController.java
| Rule |
Violation |
Priority |
Line |
| ExcessiveImports |
A high number of imports can indicate a high degree of coupling within an object. |
3 |
1–138 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
3 |
89 |
| PreserveStackTrace |
Thrown exception does not preserve the stack trace of exception 'e' on all code paths |
3 |
93 |
| PreserveStackTrace |
Thrown exception does not preserve the stack trace of exception 'e' on all code paths |
3 |
115 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
3 |
135 |
civitas/bboard/server/controllers/RetrieveHashController.java
| Rule |
Violation |
Priority |
Line |
| UnusedPrivateMethod |
Avoid unused private methods such as 'apply(String, Long, Long, String)'. |
3 |
51 |
| PreserveStackTrace |
Thrown exception does not preserve the stack trace of exception 'e' on all code paths |
3 |
82 |
civitas/bboard/server/controllers/RetrievePostsController.java
| Rule |
Violation |
Priority |
Line |
| UnusedPrivateMethod |
Avoid unused private methods such as 'apply(String)'. |
3 |
23 |
civitas/bboard/server/electioncache/ElectionCacheRepository.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
7 |
civitas/bboard/server/electioncache/UpdateCache.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
15 |
civitas/common/CheckAccess.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/common/Configuration.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
7 |
civitas/common/ConvertFromXml.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
15 |
civitas/common/ConvertToXml.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
12 |
civitas/common/GetPrivateKey.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
19 |
| UseConcurrentHashMap |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
3 |
24 |
civitas/common/GetPublicKey.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
18 |
| UseConcurrentHashMap |
If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation |
3 |
22 |
civitas/common/LoggerService.java
| Rule |
Violation |
Priority |
Line |
| ServiceClassField |
Services have only @Autowired fields |
3 |
11 |
civitas/common/ballot/CreateEmptyBallot.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
10 |
| AvoidLiteralsInIfCondition |
Avoid using literals such as 2 in if statements |
3 |
16 |
civitas/common/ballot/RecordOnePairInBallot.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
civitas/common/ballotdesign/CalculateBallotLength.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/common/ballotdesign/CalculatePositionInBallot.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/common/ballotdesign/CheckBallotAgainstBallotDesign.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
civitas/common/ballotdesign/CreateBallotDesign.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
3 |
civitas/common/ballotdesign/DecomposeBallot.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
25 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
3 |
50 |
| AvoidInstantiatingObjectsInLoops |
Avoid instantiating new objects inside loops |
3 |
80–81 |
civitas/common/ballotdesign/GetIndexOfCandidate.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
3 |
| CompareObjectsWithEquals |
Use equals() to compare object references. |
3 |
7 |
| UseEqualsToCompareStrings |
Use equals() to compare strings instead of '==' or '!=' |
3 |
7 |
civitas/common/ballotdesign/GetNthContext.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
8 |
civitas/common/ballotdesign/ListContextsNeeded.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
8 |
civitas/common/ballotdesign/TallyVote.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
18 |
| CyclomaticComplexity |
The method 'apply(String, ElGamalMsg, String, TallyState, Map<CivitasBigInteger, VoteChoice>)' has a cyclomatic complexity of 14. |
3 |
26 |
| PreserveStackTrace |
Thrown exception does not preserve the stack trace of exception 'e' on all code paths |
3 |
57 |
civitas/common/board/GetContentCommitmentForBoard.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
3 |
civitas/common/capabilityencryption/EncryptCapability.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
16 |
civitas/common/election/GetBaseContext.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/common/election/GetBlockName.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
9 |
civitas/common/election/GetContextForBlock.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
9 |
civitas/common/election/GetElectionAbandonmentReporter.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
3 |
civitas/common/election/GetVoterBlockForBlock.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
9 |
civitas/common/election/IsVoterSubmissionInBlock.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
civitas/common/electionresults/GetComputerForTeller.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/common/electionresults/GetMetaForTeller.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
9 |
civitas/common/electoralroll/GetMetaForElectoralRollCapabilityShares.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
5 |
civitas/common/encryptedchoice/EncryptChoice.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
15 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
3 |
24 |
civitas/common/mix/AddCommitmentToMix.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
8 |
civitas/common/mix/capabilityelementrevelation/VerifyMixCapabilityElementRevelation.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
13 |
civitas/common/mix/capabilitymix/AddEncryptedCapability.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
7 |
civitas/common/mix/capabilitymix/GetCapabilityMixMeta.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
civitas/common/mix/capabilitymix/GetMixConfirmationMeta.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
5 |
civitas/common/mix/capabilitymix/GetReencryptedCapabilityMix.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
12 |
civitas/common/mix/elementrevelation/VerifyMixElementRevelation.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
18 |
| AvoidThrowingNullPointerException |
Avoid throwing null pointer exceptions. |
1 |
37 |
civitas/common/mix/hashrevelation/GetMetaForMixHashRevelation.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
civitas/common/mix/revelation/GetMixRevelationMeta.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
12 |
| AvoidThrowingNullPointerException |
Avoid throwing null pointer exceptions. |
1 |
23 |
civitas/common/mix/revelation/VerifyMixRevelation.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
16 |
| CyclomaticComplexity |
The method 'apply(MixRevelation, ElGamalPublicKey, VoterMix, VoterMix, VoterMix, boolean[])' has a cyclomatic complexity of 10. |
3 |
23 |
| UseVarargs |
Consider using varargs for methods or constructors which take an array the last parameter. |
4 |
29 |
| UnusedAssignment |
The initializer for variable 'fromIndex' is never used (overwritten on lines 54 and 60) |
3 |
45 |
| UnusedAssignment |
The initializer for variable 'toIndex' is never used (overwritten on lines 55 and 61) |
3 |
46 |
| UnusedAssignment |
The initializer for variable 'fromMix' is never used (overwritten on lines 52 and 58) |
3 |
47 |
| UnusedAssignment |
The initializer for variable 'toMix' is never used (overwritten on lines 53 and 59) |
3 |
48 |
civitas/common/mix/voteelementrevelation/VerifyMixVoteElementRevelation.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
15 |
| AvoidThrowingNullPointerException |
Avoid throwing null pointer exceptions. |
1 |
28 |
civitas/common/mix/votemix/AddVoteAndCommitmentToVoteMix.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
| AvoidThrowingNullPointerException |
Avoid throwing null pointer exceptions. |
1 |
20 |
civitas/common/mix/votemix/AddVoteToVoteMix.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
civitas/common/mix/votemix/GetReencryptedVoteFromMix.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
13 |
| AvoidThrowingNullPointerException |
Avoid throwing null pointer exceptions. |
1 |
25 |
civitas/common/mix/votemix/GetVoteMixMeta.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
12 |
| AvoidThrowingNullPointerException |
Avoid throwing null pointer exceptions. |
1 |
20 |
civitas/common/tabteller/ConstructTabTellerKeyShareCommitment.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
15 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
3 |
28 |
civitas/common/tabteller/voterblockcontents/GetTabTellerVoterBlockContentsMeta.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
3 |
civitas/common/tallystate/CreateTallyState.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
5 |
civitas/common/tallystate/RecordBeat.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/common/verifiablevote/VerifyVerifiableVote.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
12 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
3 |
20 |
civitas/common/votercapabilitysharesandproofs/VerifyVoterCapabilitySharesAndProof.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
22 |
| CyclomaticComplexity |
The method 'apply(VoterCapabilitySharesAndProof, ElGamalSignedCiphertext[], ElGamalPublicKey, ElGamalPublicKey, String, int)' has a cyclomatic complexity of 11. |
3 |
36 |
| AvoidThrowingNullPointerException |
Avoid throwing null pointer exceptions. |
1 |
45 |
| RelianceOnDefaultCharset |
Specify a character set instead of relying on the default charset |
3 |
54 |
civitas/common/votersubmission/CheckVoterSubmission.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
16 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
3 |
28 |
| CognitiveComplexity |
The method 'apply(BallotDesign, VoterSubmission, int, String, CiphertextList, ElGamalPublicKey)' has a cognitive complexity of 15, current threshold is 15 |
3 |
33 |
| CyclomaticComplexity |
The method 'apply(BallotDesign, VoterSubmission, int, String, CiphertextList, ElGamalPublicKey)' has a cyclomatic complexity of 15. |
3 |
33 |
| LooseCoupling |
Avoid using implementation types like 'CiphertextList'; use the interface instead |
3 |
38 |
civitas/common/votersubmission/CreateVoterSubmission.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
8 |
civitas/common/votersubmission/GetMetaForVoterSubmission.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/result/CalculateStrengths.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
8 |
civitas/result/CalculateWinnerList.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
| LinguisticNaming |
Linguistics Antipattern - The field 'isFullyIgnored' indicates linguistically it is a boolean, but it is 'IsFullyIgnored' |
3 |
22 |
| AvoidInstantiatingObjectsInLoops |
Avoid instantiating new objects inside loops |
3 |
34 |
civitas/result/CompareBeats.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/result/ComputeWinners.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
10 |
| UseVarargs |
Consider using varargs for methods or constructors which take an array the last parameter. |
4 |
15 |
civitas/result/FormatResult.java
civitas/result/InitialMatrix.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
| CompareObjectsWithEquals |
Use equals() to compare object references. |
3 |
15 |
civitas/result/IsFullyIgnored.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
6 |
civitas/result/MakeCloudWordList.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
9 |
| AvoidInstantiatingObjectsInLoops |
Avoid instantiating new objects inside loops |
3 |
17 |
civitas/result/Max.java
| Rule |
Violation |
Priority |
Line |
| ShortClassName |
Avoid short class names like Max |
4 |
7 |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
7 |
civitas/result/Min.java
| Rule |
Violation |
Priority |
Line |
| ShortClassName |
Avoid short class names like Min |
4 |
7 |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
7 |
civitas/result/TransitiveClosure.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
7 |
civitas/util/CivitasBigIntegerDeserializer.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
13 |
civitas/util/CivitasBigIntegerSerializer.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
civitas/util/GetReaderForFile.java
| Rule |
Violation |
Priority |
Line |
| ClassesShouldBeKnown |
Classes should be either Data, Service,Controller,Repository |
3 |
11 |
