PMD Results

The following document contains the results of PMD 7.17.0.

Violations By Priority

Priority 1

coder - io/github/magwas/coder/RunCommandService.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 19

coder - io/github/magwas/coder/command/WriteFilesCommandService.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 83

coder - io/github/magwas/coder/dependencies/LineReaderWrapper.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 20

coder - io/github/magwas/coder/file/FileDeletionService.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 19

coder - io/github/magwas/coder/file/FileWriterService.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 21

coder - io/github/magwas/coder/file/XMLFileWriterService.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 80

coder - io/github/magwas/coder/dependencies/tests/ObjectMapperWrapperStub.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 31

coder - io/github/magwas/coder/tests/RunCommandServiceStub.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 14

Priority 2

coder - io/github/magwas/coder/command/GoCommandService.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'context' 50

coder - io/github/magwas/coder/command/ReadFilesCommandService.java

Rule Violation Line
SystemPrintln Usage of System.out/err 64

coder - io/github/magwas/coder/dependencies/SystemWrapper.java

Rule Violation Line
SystemPrintln Usage of System.out/err 12

Priority 3

coder - io/github/magwas/coder/CoderApplication.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 23
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 23
CloseResource Ensure that resources like this AnnotationConfigApplicationContext object are closed after use 24

coder - io/github/magwas/coder/ErrorMessages.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3

coder - io/github/magwas/coder/MainLoopService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 23
AutowiredFields @Autowired fields naming conventions 29
AutowiredFields @Autowired fields naming conventions 32
AutowiredFields @Autowired fields naming conventions 38
CognitiveComplexity The method 'apply()' has a cognitive complexity of 19, current threshold is 15 43
CyclomaticComplexity The method 'apply()' has a cyclomatic complexity of 14. 43
NPathComplexity The method 'apply()' has an NPath complexity of 388, current threshold is 200 43
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 57
AssignmentInOperand Avoid assignment to contextData in operand 60
AssignmentInOperand Avoid assignment to contextData in operand 61
AssignmentInOperand Avoid assignment to contextData in operand 62
AssignmentInOperand Avoid assignment to contextData in operand 63
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 66
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 69
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 74

coder - io/github/magwas/coder/RunCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 13
MethodArgumentCouldBeFinal Parameter 'command' is not assigned and could be declared final 15

coder - io/github/magwas/coder/command/AddToHistoryCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 14
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 17
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 17
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 18

coder - io/github/magwas/coder/command/AskAICommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 28
AutowiredFields @Autowired fields naming conventions 31
AutowiredFields @Autowired fields naming conventions 34
AutowiredFields @Autowired fields naming conventions 37
AutowiredFields @Autowired fields naming conventions 40
AutowiredFields @Autowired fields naming conventions 43
AutowiredFields @Autowired fields naming conventions 46
AutowiredFields @Autowired fields naming conventions 49
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 52
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 52
AvoidLiteralsInIfCondition Avoid using literals such as 3 in if statements 53
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 57
AvoidLiteralsInIfCondition Avoid using literals such as 200 in if statements 74

coder - io/github/magwas/coder/command/ClearCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 15
MissingOverride The method 'apply(ProcessingContextData, List<String>)' is missing an @Override annotation. 17
MethodArgumentCouldBeFinal Parameter 'contextData' is not assigned and could be declared final 17
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 17

coder - io/github/magwas/coder/command/ExitCommandService.java

Rule Violation Line
MissingOverride The method 'apply(ProcessingContextData, List<String>)' is missing an @Override annotation. 10
MethodArgumentCouldBeFinal Parameter 'contextData' is not assigned and could be declared final 10
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 10

coder - io/github/magwas/coder/command/GoCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 22
AutowiredFields @Autowired fields naming conventions 25
MissingOverride The method 'apply(ProcessingContextData, List<String>)' is missing an @Override annotation. 30
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 30
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 35
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 52

coder - io/github/magwas/coder/command/ListCommandsCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 13
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 16
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 16

coder - io/github/magwas/coder/command/PersonalityCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 16
MissingOverride The method 'apply(ProcessingContextData, List<String>)' is missing an @Override annotation. 18
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 18
ConfusingTernary Avoid if (x != y) ..; else ..; 1929
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 19

coder - io/github/magwas/coder/command/PrintContentCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 13
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 16
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 16

coder - io/github/magwas/coder/command/PrintMetaCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 13
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 16
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 16

coder - io/github/magwas/coder/command/PrintReasoningCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 13
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 16
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 16

coder - io/github/magwas/coder/command/ReadFilesCommandService.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 17
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 17
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 18
MethodArgumentCouldBeFinal Parameter 'dir' is not assigned and could be declared final 29
MethodArgumentCouldBeFinal Parameter 'xml' is not assigned and could be declared final 29
MethodArgumentCouldBeFinal Parameter 'xml' is not assigned and could be declared final 48
MethodArgumentCouldBeFinal Parameter 'absoluteProjectRoot' is not assigned and could be declared final 48

coder - io/github/magwas/coder/command/SystemInstructionsCommandService.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 14
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 14
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 15
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 22

coder - io/github/magwas/coder/command/TestCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 16
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 19
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 19
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 20
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 30

coder - io/github/magwas/coder/command/WriteFilesCommandService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 18
AutowiredFields @Autowired fields naming conventions 21
AutowiredFields @Autowired fields naming conventions 24
AutowiredFields @Autowired fields naming conventions 27
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 30
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 30
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 38
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 44
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 44
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 56
MethodArgumentCouldBeFinal Parameter 'modifiedFiles' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'deletedFiles' is not assigned and could be declared final 68
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 72
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 76
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 81
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 81

coder - io/github/magwas/coder/config/ApiKeyConfigService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 11

coder - io/github/magwas/coder/config/ConfigLoadService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 20
AutowiredFields @Autowired fields naming conventions 23
AutowiredFields @Autowired fields naming conventions 26

coder - io/github/magwas/coder/config/ConfigState.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

coder - io/github/magwas/coder/config/PersonalityService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 11
MethodArgumentCouldBeFinal Parameter 'personalityName' is not assigned and could be declared final 13

coder - io/github/magwas/coder/conversation/ConversationState.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 10

coder - io/github/magwas/coder/dependencies/DirectoryWrapper.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

coder - io/github/magwas/coder/dependencies/HttpClientWrapper.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 8

coder - io/github/magwas/coder/dependencies/LineReaderWrapper.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 12
CloseResource Ensure that resources like this Terminal object are closed after use 17

coder - io/github/magwas/coder/dependencies/ObjectMapperWrapper.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 9

coder - io/github/magwas/coder/dependencies/ProcessBuilderWrapper.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

coder - io/github/magwas/coder/dependencies/SystemWrapper.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6
MethodArgumentCouldBeFinal Parameter 'status' is not assigned and could be declared final 7
DoNotTerminateVM System.exit() should not be used in J2EE/JEE apps 8
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 11

coder - io/github/magwas/coder/dependencies/TimeWrapper.java

Rule Violation Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 6

coder - io/github/magwas/coder/exec/CommandExecutionService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 16
MethodArgumentCouldBeFinal Parameter 'command' is not assigned and could be declared final 18
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 27

coder - io/github/magwas/coder/file/FileDeletionService.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 13

coder - io/github/magwas/coder/file/FileWriterService.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 14
MethodArgumentCouldBeFinal Parameter 'content' is not assigned and could be declared final 14

coder - io/github/magwas/coder/file/PathUtil.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 8
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 8

coder - io/github/magwas/coder/file/XMLFileWriterService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 21
AutowiredFields @Autowired fields naming conventions 24
AutowiredFields @Autowired fields naming conventions 27
AutowiredFields @Autowired fields naming conventions 30
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 32
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 41
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 41
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'modifiedFiles' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'deletedFiles' is not assigned and could be declared final 65
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 69
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 73
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 78

coder - io/github/magwas/coder/file/XmlProcessingUtil.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 21
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 33
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 45

coder - io/github/magwas/coder/file/XmlUtil.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'content' is not assigned and could be declared final 6

coder - io/github/magwas/coder/openrouter/OpenRouterClientService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 17
AutowiredFields @Autowired fields naming conventions 20
MethodArgumentCouldBeFinal Parameter 'requestBody' is not assigned and could be declared final 22
MethodArgumentCouldBeFinal Parameter 'authHeader' is not assigned and could be declared final 22

coder - io/github/magwas/coder/openrouter/OpenRouterRequestService.java

Rule Violation Line
AutowiredFields @Autowired fields naming conventions 15
MethodArgumentCouldBeFinal Parameter 'messages' is not assigned and could be declared final 17
MethodArgumentCouldBeFinal Parameter 'modelId' is not assigned and could be declared final 17
MethodArgumentCouldBeFinal Parameter 'doReasoning' is not assigned and could be declared final 17

coder - io/github/magwas/coder/config/tests/ConfigLoadServiceStub.java

Rule Violation Line
ExceptionAsFlowControl Exception thrown at line 16 is caught in this block. 2223
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 22

coder - io/github/magwas/coder/dependencies/tests/ObjectMapperWrapperStub.java

Rule Violation Line
AvoidAccessibilityAlteration You should not modify visibility of constructors, methods or fields using setAccessible() 23
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 30

coder - io/github/magwas/coder/dependencies/tests/SystemExitSimulationException.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3
MethodArgumentCouldBeFinal Parameter 'exitCode' is not assigned and could be declared final 6

coder - io/github/magwas/coder/file/tests/XMLFileWriterServiceTest.java

Rule Violation Line
JUnit5TestShouldBePackagePrivate JUnit 5 tests should be package-private. 17
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 30
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 38
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 46

coder - io/github/magwas/coder/openrouter/tests/OpenRouterClientServiceStub.java

Rule Violation Line
UseExplicitTypes Use Explicit Types 20

coder - io/github/magwas/coder/openrouter/tests/OpenRouterClientServiceTest.java

Rule Violation Line
JUnit5TestShouldBePackagePrivate JUnit 5 tests should be package-private. 19
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 32

coder - io/github/magwas/coder/tests/MainLoopTestData.java

Rule Violation Line
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 13

Priority 4

coder - io/github/magwas/coder/config/ApiKeyConfigService.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ErrorMessages': 'API_KEY_ERROR' is already in scope because it is inherited by an enclosing type 15

coder - io/github/magwas/coder/file/FileWriterService.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ErrorMessages': 'FILE_ERROR' is already in scope because it is inherited by an enclosing type 21

Files

coder - io/github/magwas/coder/CoderApplication.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 23
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 23
CloseResource Ensure that resources like this AnnotationConfigApplicationContext object are closed after use 3 24

coder - io/github/magwas/coder/ErrorMessages.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 3

coder - io/github/magwas/coder/MainLoopService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 23
AutowiredFields @Autowired fields naming conventions 3 29
AutowiredFields @Autowired fields naming conventions 3 32
AutowiredFields @Autowired fields naming conventions 3 38
CognitiveComplexity The method 'apply()' has a cognitive complexity of 19, current threshold is 15 3 43
CyclomaticComplexity The method 'apply()' has a cyclomatic complexity of 14. 3 43
NPathComplexity The method 'apply()' has an NPath complexity of 388, current threshold is 200 3 43
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 57
AssignmentInOperand Avoid assignment to contextData in operand 3 60
AssignmentInOperand Avoid assignment to contextData in operand 3 61
AssignmentInOperand Avoid assignment to contextData in operand 3 62
AssignmentInOperand Avoid assignment to contextData in operand 3 63
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 66
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 69
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 3 74

coder - io/github/magwas/coder/RunCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 13
MethodArgumentCouldBeFinal Parameter 'command' is not assigned and could be declared final 3 15
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 1 19

coder - io/github/magwas/coder/command/AddToHistoryCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 14
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 17
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 17
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 3 18

coder - io/github/magwas/coder/command/AskAICommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 28
AutowiredFields @Autowired fields naming conventions 3 31
AutowiredFields @Autowired fields naming conventions 3 34
AutowiredFields @Autowired fields naming conventions 3 37
AutowiredFields @Autowired fields naming conventions 3 40
AutowiredFields @Autowired fields naming conventions 3 43
AutowiredFields @Autowired fields naming conventions 3 46
AutowiredFields @Autowired fields naming conventions 3 49
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 52
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 52
AvoidLiteralsInIfCondition Avoid using literals such as 3 in if statements 3 53
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 57
AvoidLiteralsInIfCondition Avoid using literals such as 200 in if statements 3 74

coder - io/github/magwas/coder/command/ClearCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 15
MissingOverride The method 'apply(ProcessingContextData, List<String>)' is missing an @Override annotation. 3 17
MethodArgumentCouldBeFinal Parameter 'contextData' is not assigned and could be declared final 3 17
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 17

coder - io/github/magwas/coder/command/ExitCommandService.java

Rule Violation Priority Line
MissingOverride The method 'apply(ProcessingContextData, List<String>)' is missing an @Override annotation. 3 10
MethodArgumentCouldBeFinal Parameter 'contextData' is not assigned and could be declared final 3 10
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 10

coder - io/github/magwas/coder/command/GoCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 22
AutowiredFields @Autowired fields naming conventions 3 25
MissingOverride The method 'apply(ProcessingContextData, List<String>)' is missing an @Override annotation. 3 30
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 30
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 35
AvoidReassigningParameters Avoid reassigning parameters such as 'context' 2 50
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 3 52

coder - io/github/magwas/coder/command/ListCommandsCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 13
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 16
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 16

coder - io/github/magwas/coder/command/PersonalityCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 16
MissingOverride The method 'apply(ProcessingContextData, List<String>)' is missing an @Override annotation. 3 18
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 18
ConfusingTernary Avoid if (x != y) ..; else ..; 3 1929
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 3 19

coder - io/github/magwas/coder/command/PrintContentCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 13
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 16
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 16

coder - io/github/magwas/coder/command/PrintMetaCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 13
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 16
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 16

coder - io/github/magwas/coder/command/PrintReasoningCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 13
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 16
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 16

coder - io/github/magwas/coder/command/ReadFilesCommandService.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 17
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 17
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 3 18
MethodArgumentCouldBeFinal Parameter 'dir' is not assigned and could be declared final 3 29
MethodArgumentCouldBeFinal Parameter 'xml' is not assigned and could be declared final 3 29
MethodArgumentCouldBeFinal Parameter 'xml' is not assigned and could be declared final 3 48
MethodArgumentCouldBeFinal Parameter 'absoluteProjectRoot' is not assigned and could be declared final 3 48
SystemPrintln Usage of System.out/err 2 64

coder - io/github/magwas/coder/command/SystemInstructionsCommandService.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 14
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 14
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 3 15
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 22

coder - io/github/magwas/coder/command/TestCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 16
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 19
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 19
AvoidLiteralsInIfCondition Avoid using literals such as 2 in if statements 3 20
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 30

coder - io/github/magwas/coder/command/WriteFilesCommandService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 18
AutowiredFields @Autowired fields naming conventions 3 21
AutowiredFields @Autowired fields naming conventions 3 24
AutowiredFields @Autowired fields naming conventions 3 27
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 30
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 30
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 38
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 3 44
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 44
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 3 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 56
MethodArgumentCouldBeFinal Parameter 'modifiedFiles' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'deletedFiles' is not assigned and could be declared final 3 68
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 72
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 76
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 81
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 3 81
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 1 83

coder - io/github/magwas/coder/config/ApiKeyConfigService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 11
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ErrorMessages': 'API_KEY_ERROR' is already in scope because it is inherited by an enclosing type 4 15

coder - io/github/magwas/coder/config/ConfigLoadService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 20
AutowiredFields @Autowired fields naming conventions 3 23
AutowiredFields @Autowired fields naming conventions 3 26

coder - io/github/magwas/coder/config/ConfigState.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

coder - io/github/magwas/coder/config/PersonalityService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 11
MethodArgumentCouldBeFinal Parameter 'personalityName' is not assigned and could be declared final 3 13

coder - io/github/magwas/coder/conversation/ConversationState.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 10

coder - io/github/magwas/coder/dependencies/DirectoryWrapper.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

coder - io/github/magwas/coder/dependencies/HttpClientWrapper.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 8

coder - io/github/magwas/coder/dependencies/LineReaderWrapper.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 12
CloseResource Ensure that resources like this Terminal object are closed after use 3 17
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 1 20

coder - io/github/magwas/coder/dependencies/ObjectMapperWrapper.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 9

coder - io/github/magwas/coder/dependencies/ProcessBuilderWrapper.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

coder - io/github/magwas/coder/dependencies/SystemWrapper.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6
MethodArgumentCouldBeFinal Parameter 'status' is not assigned and could be declared final 3 7
DoNotTerminateVM System.exit() should not be used in J2EE/JEE apps 3 8
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 11
SystemPrintln Usage of System.out/err 2 12

coder - io/github/magwas/coder/dependencies/TimeWrapper.java

Rule Violation Priority Line
ClassesShouldBeKnown Classes should be either Data, Service,Controller,Repository 3 6

coder - io/github/magwas/coder/exec/CommandExecutionService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 16
MethodArgumentCouldBeFinal Parameter 'command' is not assigned and could be declared final 3 18
RelianceOnDefaultCharset Specify a character set instead of relying on the default charset 3 27

coder - io/github/magwas/coder/file/FileDeletionService.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 3 13
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 1 19

coder - io/github/magwas/coder/file/FileWriterService.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 3 14
MethodArgumentCouldBeFinal Parameter 'content' is not assigned and could be declared final 3 14
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 1 21
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ErrorMessages': 'FILE_ERROR' is already in scope because it is inherited by an enclosing type 4 21

coder - io/github/magwas/coder/file/PathUtil.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 8
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 3 8

coder - io/github/magwas/coder/file/XMLFileWriterService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 21
AutowiredFields @Autowired fields naming conventions 3 24
AutowiredFields @Autowired fields naming conventions 3 27
AutowiredFields @Autowired fields naming conventions 3 30
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 3 32
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 3 41
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 3 41
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'modifiedFiles' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'deletedFiles' is not assigned and could be declared final 3 65
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 69
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 73
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'currentDir' is not assigned and could be declared final 3 78
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 1 80

coder - io/github/magwas/coder/file/XmlProcessingUtil.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 3 21
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 3 33
MethodArgumentCouldBeFinal Parameter 'xmlContent' is not assigned and could be declared final 3 45

coder - io/github/magwas/coder/file/XmlUtil.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'content' is not assigned and could be declared final 3 6

coder - io/github/magwas/coder/openrouter/OpenRouterClientService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 17
AutowiredFields @Autowired fields naming conventions 3 20
MethodArgumentCouldBeFinal Parameter 'requestBody' is not assigned and could be declared final 3 22
MethodArgumentCouldBeFinal Parameter 'authHeader' is not assigned and could be declared final 3 22

coder - io/github/magwas/coder/openrouter/OpenRouterRequestService.java

Rule Violation Priority Line
AutowiredFields @Autowired fields naming conventions 3 15
MethodArgumentCouldBeFinal Parameter 'messages' is not assigned and could be declared final 3 17
MethodArgumentCouldBeFinal Parameter 'modelId' is not assigned and could be declared final 3 17
MethodArgumentCouldBeFinal Parameter 'doReasoning' is not assigned and could be declared final 3 17

coder - io/github/magwas/coder/config/tests/ConfigLoadServiceStub.java

Rule Violation Priority Line
ExceptionAsFlowControl Exception thrown at line 16 is caught in this block. 3 2223
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 22

coder - io/github/magwas/coder/dependencies/tests/ObjectMapperWrapperStub.java

Rule Violation Priority Line
AvoidAccessibilityAlteration You should not modify visibility of constructors, methods or fields using setAccessible() 3 23
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 30
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 1 31

coder - io/github/magwas/coder/dependencies/tests/SystemExitSimulationException.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 3
MethodArgumentCouldBeFinal Parameter 'exitCode' is not assigned and could be declared final 3 6

coder - io/github/magwas/coder/file/tests/XMLFileWriterServiceTest.java

Rule Violation Priority Line
JUnit5TestShouldBePackagePrivate JUnit 5 tests should be package-private. 3 17
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 30
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 38
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 46

coder - io/github/magwas/coder/openrouter/tests/OpenRouterClientServiceStub.java

Rule Violation Priority Line
UseExplicitTypes Use Explicit Types 3 20

coder - io/github/magwas/coder/openrouter/tests/OpenRouterClientServiceTest.java

Rule Violation Priority Line
JUnit5TestShouldBePackagePrivate JUnit 5 tests should be package-private. 3 19
UnitTestContainsTooManyAsserts Unit tests should not contain more than 1 assert(s). 3 32

coder - io/github/magwas/coder/tests/MainLoopTestData.java

Rule Violation Priority Line
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 13

coder - io/github/magwas/coder/tests/RunCommandServiceStub.java

Rule Violation Priority Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception type RuntimeException. 1 14